hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18782) Module untangling work
Date Sat, 09 Sep 2017 23:21:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160112#comment-16160112
] 

Appy commented on HBASE-18782:
------------------------------

lgtm.
imo, 5 lines comments on top of classes don't look any better. :-)
I think things will drift back to everything depending on annotations again, which kind of
makes sense to me. I guess in any future, if we want hbase classes to be well labelled, that's
the only way(?). Btw, I filtered out that module from my structure101 view.
But it's a nit right now, and meat of the change is untangling other deps.
So +1.


> Module untangling work
> ----------------------
>
>                 Key: HBASE-18782
>                 URL: https://issues.apache.org/jira/browse/HBASE-18782
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>         Attachments: HBASE-18782.master.001.patch, HBASE-18782.master.002.patch, HBASE-18782.master.002.patch,
HBASE-18782.master.003.patch
>
>
> Here is a bit of module untangling work done using structure 101. In a few places we
depend on modules but are not making use of the dependency. In other places we depended on
a module just because we had one references only, one we could undo.
> After this little exercise, we have nicer layering and stuff like hbase-protocol and
hbase-protocol-shaded no longer depend on other hbase components.  Not everything depends
on annotations anymore.
> There is way more work to do here but this will do for now.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message