hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18757) Fix Improper bitwise & in BucketCache offset calculation
Date Tue, 05 Sep 2017 23:56:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154589#comment-16154589
] 

Hudson commented on HBASE-18757:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #220 (See [https://builds.apache.org/job/HBase-1.2-JDK7/220/])
HBASE-18757 Fix improper bitwise & in bucketcache offset calculation (tedyu: rev dde799577bf190cb5a4b4b2fcaab72183d3c39c9)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java


> Fix Improper bitwise & in BucketCache offset calculation
> --------------------------------------------------------
>
>                 Key: HBASE-18757
>                 URL: https://issues.apache.org/jira/browse/HBASE-18757
>             Project: HBase
>          Issue Type: Bug
>          Components: BucketCache
>            Reporter: Zach York
>            Assignee: Zach York
>             Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
>         Attachments: HBASE-18757.branch-1.3.001.patch, HBASE-18757.master.001.patch,
HBASE-18757.master.002.patch
>
>
> Offset calculation for BucketCache entries incorrectly uses an int literal to try to
ensure that the offset is positive. However, because it uses the string literal 0xFFFFFFFF
which java uses at an int (which is negative). When it does the bitwise &, java sign extends
the int effectively undoing the original intention of the code and allowing for negative values
to slip through.
> Then the read or write to that block will fail due to trying to read/write at a negative
index which causes the BucketCache to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message