hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18601) Update Htrace to 4.2
Date Sat, 16 Sep 2017 21:12:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169062#comment-16169062
] 

stack commented on HBASE-18601:
-------------------------------

[~tamaas] Fix your IDE so it does not do this 'helpful' change for you: +import java.util.*;
 We do explicit import of each class always sir.

+public class TraceUtil { Needs InterfaceAudience Private (see the adjacent classes in the
package -- I like how you put this util back up in hbase-common in here in this package...
good one). A bit of javadoc on how to use and a test even wouldn't go amiss (smile). We need
to shove this nice utility back up into htrace. Let me open issue pointing to your example
after it goes in.

Skimmed the rest. LGTM.  Thanks [~tamaas]





> Update Htrace to 4.2
> --------------------
>
>                 Key: HBASE-18601
>                 URL: https://issues.apache.org/jira/browse/HBASE-18601
>             Project: HBase
>          Issue Type: Task
>    Affects Versions: 2.0.0, 3.0.0
>            Reporter: Tamas Penzes
>            Assignee: Tamas Penzes
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18601.master.001.patch, HBASE-18601.master.002.patch, HBASE-18601.master.003
(3).patch, HBASE-18601.master.003.patch
>
>
> HTrace is not perfectly integrated into HBase, the version 3.2.0 is buggy, the upgrade
to 4.x is not trivial and would take time. It might not worth to keep it in this state, so
would be better to remove it.
> Of course it doesn't mean tracing would be useless, just that in this form the use of
HTrace 3.2 might not add any value to the project and fixing it would be far too much effort.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Based on the decision of the community we keep htrace now and update version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message