hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18298) RegionServerServices Interface cleanup for CP expose
Date Fri, 22 Sep 2017 00:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175741#comment-16175741
] 

stack commented on HBASE-18298:
-------------------------------

Yeah, name CoprocessorRSServices as CompressorRegionServerServices and method name should
be getCompressorRegionServerServices

How comes getRpcServer? Some CPs need this? I'd think CP is running in a RS. We are already
inside past the RPC. Why would a CP be meddling w/ RPC? Naughty CP!

Yeah, almost ditto for getFileSystem though I suppose they might want to get to HDFS. Above
I question this being in the Interface. Now I am fine w/ it.

Man, what is this for getRecoveringRegions ? Seems totally internal. Used by our recover regions
handler. CPs shouldn't be looking at this?

Yeah, you might just extend OnlineRegions and throw IllegalAccess if they try to change the
Region Map. It has a few of the methods that you have in here. Then it also extends Server
which is at root of RegionServerService and it also has some of the methods you have in here
plus a few other innocuous ones -- We'd do this so we don't have yet another Interface to
explain.

SecureBulkLoadEndpoint is deprecated and going away, becoming integral, so you don't have
to worry about the hack you have going on in here (smile).

I think the patch is starting to look good.




> RegionServerServices Interface cleanup for CP expose
> ----------------------------------------------------
>
>                 Key: HBASE-18298
>                 URL: https://issues.apache.org/jira/browse/HBASE-18298
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-18298.patch, HBASE-18298_V2.patch, HBASE-18298_V3.patch, HBASE-18298_V4.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message