hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
Date Wed, 06 Sep 2017 20:49:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156016#comment-16156016
] 

stack commented on HBASE-17980:
-------------------------------

bq. I didn't change Admin Interface API in this patch, should I replace all HRegionInfo to
RegionInfo in this patch ???

Yes. Admin is going to be incompatible in hbase2. It is 'ok'. I see three methods that need
to be changed.

RegionReplicaUtil is audience private so ok to change.

Yeah, looks like getMetaTableRowResultAsSplitRegion is never used. Try purging it?

Kill MutableRegionInfo I'd say. You've done this lovely cleanup. MutableRegionInfo hanging
around makes it a little dirty (smile).



> Any HRegionInfo we give out should be immutable
> -----------------------------------------------
>
>                 Key: HBASE-17980
>                 URL: https://issues.apache.org/jira/browse/HBASE-17980
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Chia-Ping Tsai
>            Assignee: Kuan-Po Tseng
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch
>
>
> This is similar to HBASE-15583.
> # Introduce RegionInfo class. HRegionInfo will extend RegionInfo.
> # Deprecate HRegionInfo to be removed in 3.0
> # RegionInfo contain all of the read-only methods of HRegionInfo
> # Add "RegionInfo Builder"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message