hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17732) Coprocessor Design Improvements
Date Tue, 26 Sep 2017 08:43:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180475#comment-16180475
] 

Hadoop QA commented on HBASE-17732:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 28s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color}
| {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 91 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 33s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 56s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  4m 59s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  5m 56s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  3m 10s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 14m  9s{color}
| {color:green} branch has no errors when building our shaded downstream artifacts. {color}
|
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 21s{color} | {color:red}
hbase-server in master has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 33s{color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 17s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m  6s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 15s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  3m 15s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m  7s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  2m 24s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m  2s{color}
| {color:green} patch has no errors when building our shaded downstream artifacts. {color}
|
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 40m 12s{color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  2m 36s{color} | {color:red}
hbase-server generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m 34s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 39s{color} | {color:green}
hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 29s{color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m  3s{color} | {color:red}
hbase-mapreduce in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 10s{color} | {color:red}
hbase-thrift in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 32s{color} | {color:green}
hbase-rsgroup in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  5m 56s{color} | {color:red}
hbase-endpoint in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 42s{color} | {color:red}
hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 32s{color} | {color:green}
hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 26s{color} | {color:green}
hbase-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  1m 53s{color} | {color:red}
The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}181m 20s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
|  |  org.apache.hadoop.hbase.coprocessor.MasterCoprocessor.getMasterService() has Optional
return type and returns explicit null  At MasterCoprocessor.java:and returns explicit null
 At MasterCoprocessor.java:[line 41] |
|  |  org.apache.hadoop.hbase.coprocessor.RegionCoprocessor.getRegionService() has Optional
return type and returns explicit null  At RegionCoprocessor.java:and returns explicit null
 At RegionCoprocessor.java:[line 49] |
| Failed junit tests | hadoop.hbase.coprocessor.TestCoprocessorInterface |
|   | hadoop.hbase.coprocessor.TestCoprocessorConfiguration |
|   | hadoop.hbase.coprocessor.TestRegionObserverStacking |
|   | hadoop.hbase.mapreduce.TestImportTSVWithTTLs |
|   | hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes |
|   | hadoop.hbase.thrift.TestThriftServer |
|   | hadoop.hbase.coprocessor.TestClassLoading |
|   | hadoop.hbase.coprocessor.TestSecureExport |
|   | hadoop.hbase.backup.master.TestBackupLogCleaner |
|   | hadoop.hbase.backup.TestBackupBoundaryTests |
|   | hadoop.hbase.backup.TestBackupMultipleDeletes |
|   | hadoop.hbase.backup.TestRestoreBoundaryTests |
|   | hadoop.hbase.backup.TestFullBackupSet |
| Timed out junit tests | org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler |
|   | org.apache.hadoop.hbase.backup.TestRemoteBackup |
|   | org.apache.hadoop.hbase.backup.TestFullBackup |
|   | org.apache.hadoop.hbase.backup.TestBackupDescribe |
|   | org.apache.hadoop.hbase.backup.TestRepairAfterFailedDelete |
|   | org.apache.hadoop.hbase.backup.TestBackupDeleteRestore |
|   | org.apache.hadoop.hbase.backup.TestIncrementalBackupDeleteTable |
|   | org.apache.hadoop.hbase.backup.TestRemoteRestore |
|   | org.apache.hadoop.hbase.backup.TestFullRestore |
|   | org.apache.hadoop.hbase.backup.TestBackupDelete |
|   | org.apache.hadoop.hbase.backup.TestIncrementalBackupMergeWithFailures |
|   | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithFailures |
|   | org.apache.hadoop.hbase.backup.TestBackupDeleteWithFailures |
|   | org.apache.hadoop.hbase.backup.TestFullBackupWithFailures |
|   | org.apache.hadoop.hbase.backup.TestBackupStatusProgress |
|   | org.apache.hadoop.hbase.backup.TestBackupRepair |
|   | org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad |
|   | org.apache.hadoop.hbase.backup.TestFullBackupSetRestoreSet |
|   | org.apache.hadoop.hbase.backup.TestBackupShowHistory |
|   | org.apache.hadoop.hbase.backup.TestIncrementalBackup |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-17732 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12889006/HBASE-17732.master.011.patch
|
| Optional Tests |  asflicense  shadedjars  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti
 checkstyle  compile  |
| uname | Linux 76329cd78e23 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 410368b |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/new-findbugs-hbase-server.html
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-unit-hbase-thrift.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-unit-hbase-endpoint.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-unit-hbase-backup.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-rsgroup hbase-endpoint
hbase-backup hbase-it hbase-examples U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/8787/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Coprocessor Design Improvements
> -------------------------------
>
>                 Key: HBASE-17732
>                 URL: https://issues.apache.org/jira/browse/HBASE-17732
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Critical
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-17732.master.001.patch, HBASE-17732.master.002.patch, HBASE-17732.master.003.patch,
HBASE-17732.master.004.patch, HBASE-17732.master.005.patch, HBASE-17732.master.006.patch,
HBASE-17732.master.007.patch, HBASE-17732.master.008.patch, HBASE-17732.master.009.patch,
HBASE-17732.master.010.patch, HBASE-17732.master.011.patch
>
>
> The two main changes are:
> * *Adding template for coprocessor type to CoprocessorEnvironment i.e. {{interface CoprocessorEnvironment<C
extends Coprocessor>}}*
>   ** Enables us to load only relevant coprocessors in hosts. Right now each type of host
loads all types of coprocs and it's only during execOperation that it checks if the coproc
is of correct type i.e. XCoprocessorHost will load XObserver, YObserver, and all others, and
will check in execOperation if {{coproc instanceOf XObserver}} and ignore the rest.
>   ** Allow sharing of a bunch functions/classes which are currently duplicated in each
host. For eg. CoprocessorOperations, CoprocessorOperationWithResult, execOperations().
> * *Introduce 4 coprocessor classes and use composition between these new classes and
and old observers*
>   ** The real gold here is, moving forward, we'll be able to break down giant everything-in-one
observers (masterobserver has 100+ functions) into smaller, more focused observers. These
smaller observer can then have different compat guarantees!!
> Here's a more detailed design doc: https://docs.google.com/document/d/1mPkM1CRRvBMZL4dBQzrus8obyvNnHhR5it2yyhiFXTg/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message