hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16769) Deprecate/remove PB references from MasterObserver and RegionServerObserver
Date Tue, 12 Sep 2017 21:03:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163648#comment-16163648
] 

Josh Elser commented on HBASE-16769:
------------------------------------

bq. One req is supposed to have only one of these 3 settings right?

I think at the protocol level, we allow any of the "limits" to be applied in one RPC/protobuf.
However, at the Java API level, we don't expose that level because this is such an infrequent
operation.

bq. Either removal of existing Quota or additon(And update is also done as an addition?)?

Yup, addition and modify are treated the same.

bq. I was not so sure abt these aspects of Quota feature and its impl, did not go with the
change on my own.

Ok. I can't imagine anyone feels strongly here, otherwise we would have had this question
and discussion before :). I'll leave the implementation as is and update the javadoc as a
part of my efforts.

> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-16769.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> 	preListSnapshot
> 	postListSnapshot
> 	preSnapshot
> 	postSnapshot
> 	preCloneSnapshot
> 	postCloneSnapshot
> 	preRestoreSnapshot
> 	postRestoreSnapshot
> 	preDeleteSnapshot
> 	postDeleteSnapshot
> 	
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetTableQuota
> 	postSetTableQuota
> 	preSetNamespaceQuota
> 	postSetNamespaceQuota
> 	
> RegionServerObserver
> 	preReplicateLogEntries
> 	postReplicateLogEntries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message