hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16769) Deprecate/remove PB references from MasterObserver and RegionServerObserver
Date Tue, 12 Sep 2017 20:00:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163561#comment-16163561
] 

Anoop Sam John commented on HBASE-16769:
----------------------------------------

At client side, when user called any of the method in the Factory, we would be creating a
specific QuotaSettings object.  This is been converted into a PB request object and pass to
server.   When calling CP hooks, we expect similar QuotaSettings objects to be created and
passed.
{code}
    Quotas.Builder builder = (quotas != null) ? quotas.toBuilder() : Quotas.newBuilder();
    if (req.hasThrottle()) applyThrottle(builder, req.getThrottle());
    if (req.hasBypassGlobals()) applyBypassGlobals(builder, req.getBypassGlobals());
    if (req.hasSpaceLimit()) applySpaceLimit(builder, req.getSpaceLimit());
{code}
One req is supposed to have only one of these 3 settings right?  Either removal of existing
Quota or additon(And update is also done as an addition?)?
I was not so sure abt these aspects of Quota feature and its impl,  did not go with the change
on my own.  Thanks 

> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-16769.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> 	preListSnapshot
> 	postListSnapshot
> 	preSnapshot
> 	postSnapshot
> 	preCloneSnapshot
> 	postCloneSnapshot
> 	preRestoreSnapshot
> 	postRestoreSnapshot
> 	preDeleteSnapshot
> 	postDeleteSnapshot
> 	
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetTableQuota
> 	postSetTableQuota
> 	preSetNamespaceQuota
> 	postSetNamespaceQuota
> 	
> RegionServerObserver
> 	preReplicateLogEntries
> 	postReplicateLogEntries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message