hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16769) Deprecate/remove PB references from MasterObserver and RegionServerObserver
Date Thu, 21 Sep 2017 15:35:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174951#comment-16174951
] 

ramkrishna.s.vasudevan commented on HBASE-16769:
------------------------------------------------

Comment on withCpCall already been said by [~chia7712]. That needs to be fixed. 
The CP hook is changing now. So since we are changing the signatures already it is fine. So
we should revisit all CP hooks if there are any other similar hooks with unwanted hooks that
is passing some private things and some unnecessary/additional things as param.
Why is that we are newly passing the new param 'withCphook' and the other deleteSnapshot()
API do not have that switch? Rest looks good to me.
bq.AC should be internal, not as a CP?
Good idea but probably a big change.

> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-16769.patch, HBASE-16769_V2.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> 	preListSnapshot
> 	postListSnapshot
> 	preSnapshot
> 	postSnapshot
> 	preCloneSnapshot
> 	postCloneSnapshot
> 	preRestoreSnapshot
> 	postRestoreSnapshot
> 	preDeleteSnapshot
> 	postDeleteSnapshot
> 	
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetUserQuota
> 	postSetUserQuota
> 	preSetTableQuota
> 	postSetTableQuota
> 	preSetNamespaceQuota
> 	postSetNamespaceQuota
> 	
> RegionServerObserver
> 	preReplicateLogEntries
> 	postReplicateLogEntries
> Note : This issue not handling Quota related CPs.  Same is handled by a subtask here
HBase-18807



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message