hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16480) Merge WALEdit and WALKey
Date Mon, 11 Sep 2017 23:48:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162247#comment-16162247
] 

stack commented on HBASE-16480:
-------------------------------

Even if we just cut down size of WALKey and WALEdit. A WALEntry has a WALKey and a WALEdit.
The WALEdit has full RegionInfo. The WALKey has regioninfo encoded AND table name (repeated
info). The WALKey carries an mvcc and a writeEntry instance though all it wants is the resultant
sequenceid... which is managed by another object altogether, the FSWALEntry -- which has no
mvcc.

Needs some work.

> Merge WALEdit and WALKey
> ------------------------
>
>                 Key: HBASE-16480
>                 URL: https://issues.apache.org/jira/browse/HBASE-16480
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-16480.master.001.patch
>
>
> No need for separate classes: 
> {code}
> // TODO: Key and WALEdit are never used separately, or in one-to-many relation, for practical
> //       purposes. They need to be merged into WALEntry.
> @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATION)
> public class WALKey implements SequenceId, Comparable<WALKey> {
> {code}
> Will reduce garbage a little and simplify code. We can get rid of WAL.Entry as well.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message