hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15071) Cleanup bypass semantic in MasterCoprocessorHost
Date Thu, 07 Sep 2017 15:07:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157052#comment-16157052

Chia-Ping Tsai commented on HBASE-15071:

Any progress? RegionCoprocessorHost has similar issue. BTW, why not remove the bypass? We
can add comment in javadoc saying "What you return will skip further core code processing"
or "What you return will be instead of the core object". The former can return something to
indicates the method invocation is not to proceed so it doesn't need the bypass. The latter
doesn't allow user to bypass anything.

> Cleanup bypass semantic in MasterCoprocessorHost
> ------------------------------------------------
>                 Key: HBASE-15071
>                 URL: https://issues.apache.org/jira/browse/HBASE-15071
>             Project: HBase
>          Issue Type: Task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Blocker
>         Attachments: HBASE-15071.patch
> Lets decide on this one before we release 2.0.0.
> A bunch of methods in MasterCoprocessorHost on the 'pre' step allow returning true which
indicates the method invocation is not to proceed.
> Not all 'pre' steps do this. Just some.
> Seems a little arbitrary.
> How we skip out if we are not proceed with the invocation is also a little arbitrary.
> When a deleteColumn call is supposed to skip out, it returns a -1, a non-procId. If we
are to skip a balance call, we log that CP said skip and then return false to indicate the
balancer did not run (why?). Elsewhere we just exit silently. In createNamespace we used to
exit silently but HBASE-14888 just changed it so we throw a BypassCoprocessorException instead...

> Lets make them all work the same way.
> (This issue comes of chat w/ Matteo)

This message was sent by Atlassian JIRA

View raw message