hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14997) Move compareOp and Comparators out of filter to client package
Date Fri, 08 Sep 2017 06:53:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158201#comment-16158201
] 

stack commented on HBASE-14997:
-------------------------------

You are right [~anoop.hbase] Thank you. Fixed.

[~enis] Will do. Thanks for review. Let me land the other related refactor for filters, then
will move the new CompareOperator up into hbase-client.

> Move compareOp and Comparators out of filter to client package
> --------------------------------------------------------------
>
>                 Key: HBASE-14997
>                 URL: https://issues.apache.org/jira/browse/HBASE-14997
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-14997.master.001.patch, HBASE-14997.master.002.patch, HBASE-14997.master.003.patch,
HBASE-14997.master.004.patch
>
>
> {{Table.checkAndPut()}} and its cousins depend on CompareOp from the filter package.
Originally, ComparaOp and ByteArrayComparable, and various "comparators" have been used in
filters, so these are in the filter package. However, for checkAndPut(), etc we depend on
the filter subpackage although these are not filter related operations. We can use some clean
up.
> {code}
>   boolean checkAndPut(byte[] row, byte[] family, byte[] qualifier,
>     CompareFilter.CompareOp compareOp, byte[] value, Put put) throws IOException;
> {code}
> Some ideas
>  - Cleanup ByteArrayComparable interface (see the TODO at the class) 
>  - Maybe introduce a {{Condition}} or a similar concept and do {{checkAndPut(Condition
condition, Put put)}} and change filters to use that as well. 
>  - Introducing Condition like thing will allow us to have an interface like: {{checkAndMutate(List<Condition>
conditions, List<Mutation> mutations)}}. 
>  - BinaryComparator, etc are not "Comparators", they are comparables. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message