hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14127) Refactor AssignmentManager.unassign() function which has lots of return statements
Date Wed, 13 Sep 2017 16:35:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164916#comment-16164916
] 

Mike Drob commented on HBASE-14127:
-----------------------------------

Is this obsolete with AMv2 being available now?

> Refactor AssignmentManager.unassign() function which has lots of return statements
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-14127
>                 URL: https://issues.apache.org/jira/browse/HBASE-14127
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>         Attachments: HBASE-14127-branch-1.patch, HBASE-14127-master.patch, HBASE-14127-master-v2.patch
>
>
> In AssignmentManager.unassign()
> * there are lots of return points
> * if condition is very non-trivial to understand
> * reuse of 'state' for different purpose makes things confusing
> A simple unfold of if-else with with better variable names should be sufficient.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message