hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
Date Mon, 11 Sep 2017 06:57:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160811#comment-16160811
] 

ramkrishna.s.vasudevan commented on HBASE-10944:
------------------------------------------------

bq.Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual
code.
Sorry. I meant that we will expose it for KVs and for the  KV#getBuffer() add a clear comment
saying that we only work with Cells.
bq.Can we resolve this and the parent? Is that presumptious? Or we waiting on the MR change
to complete?
We can close this now. Both PrefixTree and RowIndexCodecV1  use this only for test cases.
So we are good now to close this.
MR can be done seperately because as I said there is no reference to KV.getBuffer() so probably
not directly referring to what this JIRA does.

> Remove all kv.getBuffer() and kv.getRow() references existing in the code
> -------------------------------------------------------------------------
>
>                 Key: HBASE-10944
>                 URL: https://issues.apache.org/jira/browse/HBASE-10944
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 1.5.0, 2.0.0-alpha-3
>
>
> kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[].
 Removing all such instances including testcases will make the usage of Cell complete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message