hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
Date Mon, 11 Sep 2017 05:48:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160764#comment-16160764
] 

stack commented on HBASE-10944:
-------------------------------

bq. Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual
code.

To what does this refer [~ram_krish]?

bq, I just did a final search of kv.getBuffer - we have references to it in PrefixTreeCoder
and in RowIndexCodecV1.

Or just not bother w/ this holdouts? Add a comment that they need to be converted but will
do later if they become relevant again (I presume RowIndexCodecV1 has been subsummed by V2?
And prefixTreeCoder is a project that didn't take -- though it should have.... And it presumes
knowledge of KV internals).

Can we resolve this and the parent? Is that presumptious? Or we waiting on the MR change to
complete?

Thanks lads.

> Remove all kv.getBuffer() and kv.getRow() references existing in the code
> -------------------------------------------------------------------------
>
>                 Key: HBASE-10944
>                 URL: https://issues.apache.org/jira/browse/HBASE-10944
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 1.5.0, 2.0.0-alpha-3
>
>
> kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[].
 Removing all such instances including testcases will make the usage of Cell complete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message