hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-10944) Remove all kv.getBuffer() and kv.getRow() references existing in the code
Date Mon, 11 Sep 2017 04:47:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160672#comment-16160672
] 

ramkrishna.s.vasudevan commented on HBASE-10944:
------------------------------------------------

Am fine with expsosing it for Cells. Add a clear comment saying avoid using in the actual
code. 
bq. the purge of kv from mr. Should this be a 2.0 project? Should it block the resolution
of this parent issue?
The code was always trying to ensure the cells are KV how ever there is no usage of Kv.getBuffer().

I just did a final search of kv.getBuffer - we have references to it in PrefixTreeCoder and
in RowIndexCodecV1.We need to change them before we expose it for tests alone. Thanks [~saint.ack@gmail.com].


> Remove all kv.getBuffer() and kv.getRow() references existing in the code
> -------------------------------------------------------------------------
>
>                 Key: HBASE-10944
>                 URL: https://issues.apache.org/jira/browse/HBASE-10944
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 1.5.0, 2.0.0-alpha-3
>
>
> kv.getRow() and kv.getBuffers() are still used in places to form key byte[] and row byte[].
 Removing all such instances including testcases will make the usage of Cell complete.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message