Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 286F6200CF8 for ; Wed, 30 Aug 2017 22:35:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 271E6169E7D; Wed, 30 Aug 2017 20:35:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 756C2169E84 for ; Wed, 30 Aug 2017 22:35:06 +0200 (CEST) Received: (qmail 73655 invoked by uid 500); 30 Aug 2017 20:35:04 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 73644 invoked by uid 99); 30 Aug 2017 20:35:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2017 20:35:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3F55AC327F for ; Wed, 30 Aug 2017 20:35:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5aSFZDkP0gX1 for ; Wed, 30 Aug 2017 20:35:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CBC0861130 for ; Wed, 30 Aug 2017 20:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EBAD2E0E29 for ; Wed, 30 Aug 2017 20:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 30A7F24153 for ; Wed, 30 Aug 2017 20:35:00 +0000 (UTC) Date: Wed, 30 Aug 2017 20:35:00 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-18722) Replace copied guava code w/ pointer to the (shaded) lib MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 30 Aug 2017 20:35:07 -0000 stack created HBASE-18722: ----------------------------- Summary: Replace copied guava code w/ pointer to the (shaded) lib Key: HBASE-18722 URL: https://issues.apache.org/jira/browse/HBASE-18722 Project: HBase Issue Type: Bug Reporter: stack Priority: Minor I found a few bits of code copied from guava src: {code} ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied from guava source code v15 (LimitedInputStream) ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to be compatible with guava 11 to 15+. ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: * from guava v21 ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: * comparator from guava v21 {code} We can instead point back at guava implementations now we use shaded guava internally. No point having it in our code base when latest guava is on latest CLASSPATH (This wasn't always the case; this is why the code was copied into hbase). Also, there are other copies other than the above. -- This message was sent by Atlassian JIRA (v6.4.14#64029)