Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5FBF2200D0A for ; Tue, 29 Aug 2017 21:40:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5E52E167759; Tue, 29 Aug 2017 19:40:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7CB75167758 for ; Tue, 29 Aug 2017 21:40:06 +0200 (CEST) Received: (qmail 19489 invoked by uid 500); 29 Aug 2017 19:40:05 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 19478 invoked by uid 99); 29 Aug 2017 19:40:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Aug 2017 19:40:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 295131A4F22 for ; Tue, 29 Aug 2017 19:40:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id m9II8OfK1oks for ; Tue, 29 Aug 2017 19:40:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 64CC960ED5 for ; Tue, 29 Aug 2017 19:40:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 69B5BE0A29 for ; Tue, 29 Aug 2017 19:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 13CCF24147 for ; Tue, 29 Aug 2017 19:40:01 +0000 (UTC) Date: Tue, 29 Aug 2017 19:40:01 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18716) [pom cleanup] Move the replication protos into the new hbase-replication module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 29 Aug 2017 19:40:07 -0000 [ https://issues.apache.org/jira/browse/HBASE-18716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145974#comment-16145974 ] stack commented on HBASE-18716: ------------------------------- For reference, here is what he was seeing before he hacked explicit references into hbase-replication pom.xml: {code} [INFO] Compiling 20 source files to /testptch/hbase/hbase-replication/target/classes [INFO] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java: /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java uses or overrides a deprecated API. [INFO] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java: Recompile with -Xlint:deprecation for details. [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[25,68] package org.apache.hadoop.hbase.shaded.com.google.common.annotations does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[27,58] package org.apache.hadoop.hbase.shaded.com.google.protobuf does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[32,57] package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[113,79] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[21,72] package org.apache.hadoop.hbase.shaded.com.google.common.util.concurrent does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[24,64] package org.apache.hadoop.hbase.shaded.com.google.common.collect does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[25,64] package org.apache.hadoop.hbase.shaded.com.google.common.collect does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[41,57] package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[465,77] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[222,52] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java:[35,57] package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[142,4] cannot find symbol symbol: class VisibleForTesting location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[147,4] cannot find symbol symbol: class VisibleForTesting location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[151,4] cannot find symbol symbol: class VisibleForTesting location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[69,53] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[71,53] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[114,22] package ReplicationProtos does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[115,26] package ReplicationProtos does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[119,7] cannot find symbol symbol: class CodedOutputStream location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[119,31] cannot find symbol symbol: variable CodedOutputStream location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[146,5] cannot find symbol symbol: class ThreadFactoryBuilder location: class org.apache.hadoop.hbase.replication.ReplicationTableBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[146,36] cannot find symbol symbol: class ThreadFactoryBuilder location: class org.apache.hadoop.hbase.replication.ReplicationTableBase [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[103,16] cannot find symbol symbol: variable ImmutableSet location: class org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[105,26] cannot find symbol symbol: variable Sets location: class org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[163,59] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[169,59] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[474,55] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[213,39] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[214,46] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[226,39] package ReplicationProtos.ReplicationState does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[227,26] package ReplicationProtos does not exist [ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[228,22] package ReplicationProtos does not exist [INFO] 32 errors [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ {code} > [pom cleanup] Move the replication protos into the new hbase-replication module > ------------------------------------------------------------------------------- > > Key: HBASE-18716 > URL: https://issues.apache.org/jira/browse/HBASE-18716 > Project: HBase > Issue Type: Bug > Reporter: stack > > [~uagashe] has a patch that touches all modules so it is turning up some probs in our interdependencies. One such is that hbase-replication was getting its generated protobuf files via transitive include of hbase-protocol-shaded. Better if the protos for replication are made local to the hbase-replication module since that is our pattern now (colocating protos w/ their client code inside their hosting module). > Only issue is that hbase-protocol-shaded content is generated and then relocated which is a lot of 'pom'-ery to copy/paste. See if can share pom-ery via the parent pom. -- This message was sent by Atlassian JIRA (v6.4.14#64029)