Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 897ED200CF5 for ; Sun, 27 Aug 2017 13:05:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7EE43164404; Sun, 27 Aug 2017 11:05:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C74C4164403 for ; Sun, 27 Aug 2017 13:05:05 +0200 (CEST) Received: (qmail 52211 invoked by uid 500); 27 Aug 2017 11:05:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 52199 invoked by uid 99); 27 Aug 2017 11:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Aug 2017 11:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 035261A28B6 for ; Sun, 27 Aug 2017 11:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id VAokFdQ3si4o for ; Sun, 27 Aug 2017 11:05:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7388360D53 for ; Sun, 27 Aug 2017 11:05:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 82706E014A for ; Sun, 27 Aug 2017 11:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3140F2537F for ; Sun, 27 Aug 2017 11:05:00 +0000 (UTC) Date: Sun, 27 Aug 2017 11:05:00 +0000 (UTC) From: "Chia-Ping Tsai (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 27 Aug 2017 11:05:06 -0000 [ https://issues.apache.org/jira/browse/HBASE-18691?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18691: ----------------------------------- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Push to master and branch-2 > [compat 1-2] HCD remove and removeConfiguration change return type > ------------------------------------------------------------------ > > Key: HBASE-18691 > URL: https://issues.apache.org/jira/browse/HBASE-18691 > Project: HBase > Issue Type: Sub-task > Components: API > Reporter: stack > Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18691.v0.patch > > > Change made in HBASE-18008. Asking [~chia7712] if ok to undo. > Here is complaint from JACC: > {code} > hbase-client-1.2.6.jar, HColumnDescriptor.class > package org.apache.hadoop.hbase > [=E2=88=92] HColumnDescriptor.remove ( byte[ ] key ) : void 1 =20 > org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V > Change=09Effect > 1=09Return value type has been changed from void to HColumnDescriptor.=09= This method has been removed because the return type is part of the method = signature. > [=E2=88=92] HColumnDescriptor.removeConfiguration ( String key ) : void= 1 =20 > org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang= /String;)V > Change=09Effect > 1=09Return value type has been changed from void to HColumnDescriptor.=09= This method has been removed because the return type is part of the method = signature. > {code} > Binary breaking but not src breaking. See https://stackoverflow.com/quest= ions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate= -fluency-breaking for good discussion. Probably not a prob. but just in cas= e and if not really needed, will purge. -- This message was sent by Atlassian JIRA (v6.4.14#64029)