Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 16 Aug 2017 16:54:00 +0000 (UTC)
From: "Xiang Li (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13094120.1502464328000.45250.1502902440354@Atlassian.JIRA>
In-Reply-To: <JIRA.13094120.1502464328000@Atlassian.JIRA>
References: <JIRA.13094120.1502464328000@Atlassian.JIRA> <JIRA.13094120.1502464328964@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18573) Update Append and Delete to use
 Mutation#getCellList(family)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 16 Aug 2017 16:54:04 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129066#comment-16129066 ] 

Xiang Li commented on HBASE-18573:
----------------------------------

Might need to trigger Hadoop QA for hbase-server

> Update Append and Delete to use Mutation#getCellList(family)
> ------------------------------------------------------------
>
>                 Key: HBASE-18573
>                 URL: https://issues.apache.org/jira/browse/HBASE-18573
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>         Attachments: HBASE-18573.master.000.patch
>
>
> In addxxx() of Put and Increment, Mutation#getCellList(family) is called to get cell list from familyMap. But in the other 2 sub-class of Mutation: Append and Delete, the logic like Mutation#getCellList(family) is used, like
> {code}
>     List<Cell> list = familyMap.get(family);
>     if(list == null) {
>       list = new ArrayList<>(1);
>     }
> {code}
> in
> {code}
> public Delete addColumn(byte [] family, byte [] qualifier, long timestamp)
> {code}
> of Delete
> We could make them to call Mutation#getCellList(family) to get better encapsulation


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)