Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 169FF200CE0 for ; Fri, 11 Aug 2017 08:24:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1348016CE15; Fri, 11 Aug 2017 06:24:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5B3CD16CE18 for ; Fri, 11 Aug 2017 08:24:08 +0200 (CEST) Received: (qmail 5650 invoked by uid 500); 11 Aug 2017 06:24:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 5639 invoked by uid 99); 11 Aug 2017 06:24:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 06:24:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 13E961A092D for ; Fri, 11 Aug 2017 06:24:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id g0fgAExMkwu3 for ; Fri, 11 Aug 2017 06:24:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 214B45FE21 for ; Fri, 11 Aug 2017 06:24:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 82519E0051 for ; Fri, 11 Aug 2017 06:24:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 07A7324171 for ; Fri, 11 Aug 2017 06:24:01 +0000 (UTC) Date: Fri, 11 Aug 2017 06:24:01 +0000 (UTC) From: "Shibin Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 11 Aug 2017 06:24:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-18568: --------------------------------- Attachment: HBASE-18568-V1.patch > Correct Regions metric of numRegions > -------------------------------------- > > Key: HBASE-18568 > URL: https://issues.apache.org/jira/browse/HBASE-18568 > Project: HBase > Issue Type: Bug > Components: metrics > Affects Versions: 3.0.0 > Reporter: Shibin Zhang > Assignee: Shibin Zhang > Priority: Critical > Attachments: HBASE-18568-V1.patch > > > i found the value of metric numReigons in Regions is not correct. > the metric can not add or remove region correctly as region close or open. > the metric as follow: > "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions", > "numRegions" : 2, > after trouble shooting ,i found the reason is in MetricsRegionSourceImpl#MetricsRegionSourceImpl > {code:java} > agg.register(this); > ... > hashCode = regionWrapper.getRegionHashCode(); > {code} > when add the MetricsRegionSource to set ,but the hashCode has not yet initialized. > So, the setFromMap can put or remove the object correctly. > it will be better like this : > {code:java} > hashCode = regionWrapper.getRegionHashCode(); > agg.register(this); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)