Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 29 Aug 2017 02:43:00 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13094018.1502431889000.142708.1503974580214@Atlassian.JIRA>
In-Reply-To: <JIRA.13094018.1502431889000@Atlassian.JIRA>
References: <JIRA.13094018.1502431889000@Atlassian.JIRA> <JIRA.13094018.1502431889848@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18568) Correct  metric of  numRegions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 29 Aug 2017 02:43:07 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-18568:
---------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.0.0-alpha-3
                   1.5.0
                   1.4.0
                   3.0.0
           Status: Resolved  (was: Patch Available)

Thanks for the patch, Shibin.

Thanks for the review, Yu.

> Correct  metric of  numRegions
> ------------------------------
>
>                 Key: HBASE-18568
>                 URL: https://issues.apache.org/jira/browse/HBASE-18568
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 3.0.0
>            Reporter: Shibin Zhang
>            Assignee: Shibin Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-18568-V1.patch
>
>
> i found the value of  metric numReigons in Regions is not correct.
> the metric can not add or remove  region correctly as region  close or open.
> the metric  as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in MetricsRegionSourceImpl#MetricsRegionSourceImpl 
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet initialized.
> So, the setFromMap can not put or remove the object correctly. 
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)