Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6CE3C200D08 for ; Tue, 8 Aug 2017 07:06:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6B6A9166B6D; Tue, 8 Aug 2017 05:06:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3FAA166B6B for ; Tue, 8 Aug 2017 07:06:07 +0200 (CEST) Received: (qmail 29360 invoked by uid 500); 8 Aug 2017 05:06:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 29348 invoked by uid 99); 8 Aug 2017 05:06:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Aug 2017 05:06:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 25C6218070B for ; Tue, 8 Aug 2017 05:06:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KaMLV-QqYouP for ; Tue, 8 Aug 2017 05:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 88F80610D4 for ; Tue, 8 Aug 2017 05:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1087BE0996 for ; Tue, 8 Aug 2017 05:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2096724162 for ; Tue, 8 Aug 2017 05:06:00 +0000 (UTC) Date: Tue, 8 Aug 2017 05:06:00 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18528) Support to modify TableDescriptor/ColumnFamilyDescriptor through MasterObserver; Or disable that. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 08 Aug 2017 05:06:08 -0000 [ https://issues.apache.org/jira/browse/HBASE-18528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117861#comment-16117861 ] Anoop Sam John commented on HBASE-18528: ---------------------------------------- We might need the desc to be passed to CPs. This can give many details (getters).. ImmutableHTableDescriptor is again an impl class and we want to pass interfaces. TableDesc or ColumnDesc interface type only we can pass. Ya the object passed to be ImmutableHTableDescriptor (I believe that only u mean here). That object any way throw Exception while calling setters on it right. > Support to modify TableDescriptor/ColumnFamilyDescriptor through MasterObserver; Or disable that. > ------------------------------------------------------------------------------------------------- > > Key: HBASE-18528 > URL: https://issues.apache.org/jira/browse/HBASE-18528 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors, master > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Critical > Fix For: 3.0.0, 2.0.0-alpha-2 > > > We are replacing the HTableDescriptor by TableDescriptor from code base. The TableDescriptor is designed to be a read-only object so user can't modifiy it through MasterObserver. HBASE-18502 change many methods of MasterObserver to use TableDescriptor but some deprecated methods still accept the HTableDescriptor. User may be confused by why some methods can't modify the table descriptor. > In short, Should we allow user to modify the passed table descriptor? > # if yes, we should introduce a mechanism that user can return a modified table descripror > # if no, we should pass ImmutableHTableDescriptor to user. Or we just remove all methods accepting the HTableDescriptor > Ditto for HColumnDescriptor. -- This message was sent by Atlassian JIRA (v6.4.14#64029)