Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3BFEB200CFC for ; Thu, 24 Aug 2017 02:19:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3846916A054; Thu, 24 Aug 2017 00:19:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F94016A050 for ; Thu, 24 Aug 2017 02:19:04 +0200 (CEST) Received: (qmail 94974 invoked by uid 500); 24 Aug 2017 00:19:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 94963 invoked by uid 99); 24 Aug 2017 00:19:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Aug 2017 00:19:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0F9431A213A for ; Thu, 24 Aug 2017 00:19:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JAaEt3WTv-q5 for ; Thu, 24 Aug 2017 00:19:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 047925F570 for ; Thu, 24 Aug 2017 00:19:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D436AE0E1B for ; Thu, 24 Aug 2017 00:19:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 29A4D25387 for ; Thu, 24 Aug 2017 00:19:00 +0000 (UTC) Date: Thu, 24 Aug 2017 00:19:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 24 Aug 2017 00:19:05 -0000 [ https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139372#comment-16139372 ] Hudson commented on HBASE-18509: -------------------------------- FAILURE: Integrated in Jenkins build HBASE-14070.HLC #270 (See [https://builds.apache.org/job/HBASE-14070.HLC/270/]) HBASE-18509 (ADDENDUM) Fix NPEs when mocking RS clocks in tests (appy: rev bc48d841bce1dbcc31016ff55837b9f1b242e3d6) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Clocks.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java > [HLC] Finishing cleanups > ------------------------ > > Key: HBASE-18509 > URL: https://issues.apache.org/jira/browse/HBASE-18509 > Project: HBase > Issue Type: Sub-task > Reporter: Appy > Assignee: Amit Patel > Attachments: HBASE-18509.HBASE-14070.HLC.001.patch, HBASE-18509.HBASE-14070.HLC.002.patch, HBASE-18509.HBASE-14070.HLC.003.patch, HBASE-18509.HBASE-14070.HLC.004.patch, HBASE-18509.HBASE-14070.HLC.005.patch > > > Track all types of cleanups here: > - (done in 001.patch) --Rename classes to more consistent naming: SystemClock, SystemMonotonicClock, HybridLogicalClock-- > - (done in 001.patch) --Move implementations out from Clock interface. It's a simple interface of 6 fns but very overloaded right now with everything put inside it.-- > - (done in 004.patch) --Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices can just have getClocks() function.-- > {noformat} > class Clocks { > // all 3 types of clocks. > // Fns: > - update(ClockType, timestamp) > - updateAll(List\) > - int64 now(ClockType) > - List\ nowAll() > } > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)