Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 26 Aug 2017 00:13:00 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13092016.1501711714000.126495.1503706380108@Atlassian.JIRA>
In-Reply-To: <JIRA.13092016.1501711714000@Atlassian.JIRA>
References: <JIRA.13092016.1501711714000@Atlassian.JIRA> <JIRA.13092016.1501711714226@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-18507) [C++] Support for MultiPuts in
 AsyncBatchRpcRetryingCaller class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 26 Aug 2017 00:13:04 -0000


    [ https://issues.apache.org/jira/browse/HBASE-18507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142476#comment-16142476 ] 

Enis Soztutar commented on HBASE-18507:
---------------------------------------

The patch contains these which should be removed: 
{code}
+#if 0
+#endif
{code}
{code}
 LOG(ERROR) << "This is Put";
{code}
- For this: 
{code}
+        } else {
+          error_msg = "Neither HBase Get or Mutation type.";
+        }
+        pb_action->set_index(action_num);
+      } catch (const std::bad_typeid &e) {
+        error_msg = "Caught Bad TypeId.";
+      }
{code} 
you don't need this try-catch, you can just let it throw the exception for bad type, and in the else condition, you can throw an exception yourself. 
-client-test failed for me with this: 
{code}
2017-08-25 23:59:38,426 INFO  [RpcServer.reader=7,bindAddress=securecluster,port=37107] hbase.Server (RpcServer.java:processConnectionHeader(1718)) - Connection from 172.17.0.2 port: 34380 with version info: version: "2.0.0-SNAPSHOT" url: "git://securecluster/usr/src/hbase" revision: "82ada63dbc741c99646a6b0e02b6c1b25a15a43a" user: "root" date: "Fri Aug 25 23:16:11 UTC 2017" src_checksum: "2a8d19d077218871466e6e59a08836f9" version_major: 2 version_minor: 0
2017-08-25 23:59:38,607 INFO  [RpcServer.FifoWFPBQ.priority.handler=17,queue=1,port=37107] io.ByteBufferPool (ByteBufferPool.java:getBuffer(112)) - Pool already reached its max capacity : 60 and no free buffers now. Consider increasing the value for 'hbase.ipc.server.reservoir.initial.max' ?
2017-08-25 23:59:38,607 INFO  [RpcServer.FifoWFPBQ.priority.handler=16,queue=0,port=37107] io.ByteBufferPool (ByteBufferPool.java:getBuffer(112)) - Pool already reached its max capacity : 60 and no free buffers now. Consider increasing the value for 'hbase.ipc.server.reservoir.initial.max' ?
unknown file: Failure
C++ exception with description "LifoSemMPMCQueue full, can't add item" thrown in the test body.
{code} 
is it because of large batch size? Are you seeing the failure as well? 

> [C++] Support for MultiPuts in AsyncBatchRpcRetryingCaller class
> ----------------------------------------------------------------
>
>                 Key: HBASE-18507
>                 URL: https://issues.apache.org/jira/browse/HBASE-18507
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-18507.HBASE-14850.v1.patch, HBASE-18507.HBASE-14850.v2.patch, HBASE-18507.HBASE-14850.v3.patch
>
>
> We will be addressing Multi Puts changes to AsyncBatchRpcRetryingCaller class here


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)