Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C6200200CE5 for ; Sun, 6 Aug 2017 11:57:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C474A1646DF; Sun, 6 Aug 2017 09:57:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 143BA1646DD for ; Sun, 6 Aug 2017 11:57:02 +0200 (CEST) Received: (qmail 11309 invoked by uid 500); 6 Aug 2017 09:57:02 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11298 invoked by uid 99); 6 Aug 2017 09:57:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 06 Aug 2017 09:57:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C32661A1ACE for ; Sun, 6 Aug 2017 09:57:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -97.89 X-Spam-Level: X-Spam-Status: No, score=-97.89 tagged_above=-999 required=6.31 tests=[GAPPY_SUBJECT=1.312, KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PFptV2YeniGy for ; Sun, 6 Aug 2017 09:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E12215F522 for ; Sun, 6 Aug 2017 09:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6B689E08B4 for ; Sun, 6 Aug 2017 09:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C69C23FFD for ; Sun, 6 Aug 2017 09:57:00 +0000 (UTC) Date: Sun, 6 Aug 2017 09:57:00 +0000 (UTC) From: "Jui-Yu Hsieh (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 06 Aug 2017 09:57:04 -0000 [ https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115736#comment-16115736 ] Jui-Yu Hsieh commented on HBASE-18439: -------------------------------------- Thank you :)[#Sahil Aggarwal] > Subclasses of o.a.h.h.chaos.actions.Action all use the same logger > ------------------------------------------------------------------ > > Key: HBASE-18439 > URL: https://issues.apache.org/jira/browse/HBASE-18439 > Project: HBase > Issue Type: Bug > Components: integration tests > Reporter: Mike Drob > Assignee: Jui-Yu Hsieh > Priority: Minor > Labels: beginner > > A bunch of the actions all use the same logger inherited from the super class. We should have them declare distinct loggers, either each one in class or perhaps we can do something dynamically like {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the static modifier on the log field. > I'm not sure that exact incantation would actually work, but the MethodHandles approach in general is how logger resolution happens in Solr and it actually works out pretty well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)