Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6AC2B200CE9 for ; Sat, 5 Aug 2017 02:42:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5FD4416E7F3; Sat, 5 Aug 2017 00:42:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A413A16E7F2 for ; Sat, 5 Aug 2017 02:42:10 +0200 (CEST) Received: (qmail 33942 invoked by uid 500); 5 Aug 2017 00:42:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 33931 invoked by uid 99); 5 Aug 2017 00:42:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Aug 2017 00:42:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6581EC2DB6 for ; Sat, 5 Aug 2017 00:42:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id nkdzrn37X8MG for ; Sat, 5 Aug 2017 00:42:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 871C15F572 for ; Sat, 5 Aug 2017 00:42:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BA2D4E00A3 for ; Sat, 5 Aug 2017 00:42:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3652124651 for ; Sat, 5 Aug 2017 00:42:03 +0000 (UTC) Date: Sat, 5 Aug 2017 00:42:03 +0000 (UTC) From: "Xiaobing Zhou (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-18078) [C++] Harden RPC by handling various communication abnormalities MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 05 Aug 2017 00:42:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-18078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115168#comment-16115168 ] Xiaobing Zhou commented on HBASE-18078: --------------------------------------- Posted v9: # added fault injection infra, see also RpcFaultInjector and RpcClientFaultInjector # inject fault to close pipeline in ClientDispatcher::operator() to simulate the scenario to get AsyncSocketException after creating connection and before sending request # added unit test AsyncSocketException is expected, however, Broken promise for type unique_ptr is returned, will debug into this. > [C++] Harden RPC by handling various communication abnormalities > ---------------------------------------------------------------- > > Key: HBASE-18078 > URL: https://issues.apache.org/jira/browse/HBASE-18078 > Project: HBase > Issue Type: Sub-task > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HBASE-18078.000.patch, HBASE-18078.001.patch, HBASE-18078.002.patch, HBASE-18078.003.patch, HBASE-18078.004.patch, HBASE-18078.005.patch, HBASE-18078.006.patch, HBASE-18078.007.patch, HBASE-18078.008.patch, HBASE-18078.009.patch > > > RPC layer should handle various communication abnormalities (e.g. connection timeout, server aborted connection, and so on). Ideally, the corresponding exceptions should be raised and propagated through handlers of pipeline in client. -- This message was sent by Atlassian JIRA (v6.4.14#64029)