Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 10 Aug 2017 17:39:00 +0000 (UTC)
From: "Esteban Gutierrez (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13070963.1494451519000.1360.1502386740896@Atlassian.JIRA>
In-Reply-To: <JIRA.13070963.1494451519000@Atlassian.JIRA>
References: <JIRA.13070963.1494451519000@Atlassian.JIRA> <JIRA.13070963.1494451519684@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-18024) HRegion#initializeRegionInternals
 should not re-create .hregioninfo file when the region directory no longer
 exists
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 10 Aug 2017 17:39:06 -0000


     [ https://issues.apache.org/jira/browse/HBASE-18024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Esteban Gutierrez updated HBASE-18024:
--------------------------------------
    Attachment: HBASE-18024.004.patch

Thanks for the quick review [~tedyu]. I don't think there is any reason to print just the replica ID since to {{HRegionInfo.toString()}} already does that:

{code}
public String toString() {
    return "{ENCODED => " + getEncodedName() + ", " +
      HConstants.NAME + " => '" + Bytes.toStringBinary(this.regionName)
      + "', STARTKEY => '" +
      Bytes.toStringBinary(this.startKey) + "', ENDKEY => '" +
      Bytes.toStringBinary(this.endKey) + "'" +
      (isOffline()? ", OFFLINE => true": "") +
      (isSplit()? ", SPLIT => true": "") +
      ((replicaId > 0)? ", REPLICA_ID => " + replicaId : "") + "}";
  }
{code}

New patch only adds some more logging in debug mode and typo in test.

> HRegion#initializeRegionInternals should not re-create .hregioninfo file when the region directory no longer exists
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-18024
>                 URL: https://issues.apache.org/jira/browse/HBASE-18024
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment, regionserver
>    Affects Versions: 2.0.0, 1.4.0, 1.3.1, 1.2.5
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>         Attachments: HBASE-18024.001.patch, HBASE-18024.002.patch, HBASE-18024.003.patch, HBASE-18024.004.patch
>
>
> When a RegionSever attempts to open a region, during initialization the RS tries to open the {{<hbase.root.dir>/data/<table>/<region>/.hregioninfo}} file, however if the {{.hregioninfofile}} doesn't exist, the RegionServer will create a new one on {{HRegionFileSystem#checkRegionInfoOnFilesystem}}. A side effect of that tools like hbck will incorrectly assume an inconsistency due the presence of this new {{.hregioninfofile}}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)