Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7696200CFD for ; Wed, 16 Aug 2017 11:07:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D629F1685FE; Wed, 16 Aug 2017 09:07:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1C1A11685FF for ; Wed, 16 Aug 2017 11:07:09 +0200 (CEST) Received: (qmail 8544 invoked by uid 500); 16 Aug 2017 09:07:09 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 8519 invoked by uid 99); 16 Aug 2017 09:07:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Aug 2017 09:07:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9A9E51807E2 for ; Wed, 16 Aug 2017 09:07:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Ua0QG6wSr7GK for ; Wed, 16 Aug 2017 09:07:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 96D125FE6D for ; Wed, 16 Aug 2017 09:07:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 528B0E0BD0 for ; Wed, 16 Aug 2017 09:07:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 18C2725397 for ; Wed, 16 Aug 2017 09:07:01 +0000 (UTC) Date: Wed, 16 Aug 2017 09:07:01 +0000 (UTC) From: "Tamas Penzes (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-16000) Table#checkAndPut() docs are too vague MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 16 Aug 2017 09:07:11 -0000 [ https://issues.apache.org/jira/browse/HBASE-16000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Penzes updated HBASE-16000: --------------------------------- Labels: beginner (was: beginner beginners) > Table#checkAndPut() docs are too vague > -------------------------------------- > > Key: HBASE-16000 > URL: https://issues.apache.org/jira/browse/HBASE-16000 > Project: HBase > Issue Type: Bug > Components: documentation > Reporter: Nick Dimiduk > Assignee: Csaba Skrabak > Priority: Minor > Labels: beginner > Fix For: 2.0.0 > > Attachments: hbase-16000.patch > > > The docs for our CAS operations that accept a {{CompareOp}} are too vague. They're copied from the part that implies {{CompareOp.EQUAL}}, which means they don't tell you how your op, the provided {{value}}, and any present value are compared. > Only by digging into HRegion.java can I see that the operation is, for example with CompareOp.GREATER, we get {{value.compareTo(existingKeyValue) > 0}}. Javadocs should be explicit about the order of operands. -- This message was sent by Atlassian JIRA (v6.4.14#64029)