hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18716) [pom cleanup] Move the replication protos into the new hbase-replication module
Date Tue, 29 Aug 2017 19:40:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145974#comment-16145974
] 

stack commented on HBASE-18716:
-------------------------------

For reference, here is what he was seeing before he hacked explicit references into hbase-replication
pom.xml:

{code}
[INFO] Compiling 20 source files to /testptch/hbase/hbase-replication/target/classes
[INFO] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:
/testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java
uses or overrides a deprecated API.
[INFO] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:
Recompile with -Xlint:deprecation for details.
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[25,68]
package org.apache.hadoop.hbase.shaded.com.google.common.annotations does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[27,58]
package org.apache.hadoop.hbase.shaded.com.google.protobuf does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[32,57]
package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[113,79]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[21,72]
package org.apache.hadoop.hbase.shaded.com.google.common.util.concurrent does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[24,64]
package org.apache.hadoop.hbase.shaded.com.google.common.collect does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[25,64]
package org.apache.hadoop.hbase.shaded.com.google.common.collect does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[41,57]
package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[465,77]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[222,52]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java:[35,57]
package org.apache.hadoop.hbase.shaded.protobuf.generated does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[142,4]
cannot find symbol
  symbol:   class VisibleForTesting
  location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[147,4]
cannot find symbol
  symbol:   class VisibleForTesting
  location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[151,4]
cannot find symbol
  symbol:   class VisibleForTesting
  location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[69,53]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[71,53]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[114,22]
package ReplicationProtos does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[115,26]
package ReplicationProtos does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[119,7]
cannot find symbol
  symbol:   class CodedOutputStream
  location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java:[119,31]
cannot find symbol
  symbol:   variable CodedOutputStream
  location: class org.apache.hadoop.hbase.replication.ReplicationStateZKBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[146,5]
cannot find symbol
  symbol:   class ThreadFactoryBuilder
  location: class org.apache.hadoop.hbase.replication.ReplicationTableBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java:[146,36]
cannot find symbol
  symbol:   class ThreadFactoryBuilder
  location: class org.apache.hadoop.hbase.replication.ReplicationTableBase
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[103,16]
cannot find symbol
  symbol:   variable ImmutableSet
  location: class org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java:[105,26]
cannot find symbol
  symbol:   variable Sets
  location: class org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[163,59]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[169,59]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java:[474,55]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[213,39]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[214,46]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[226,39]
package ReplicationProtos.ReplicationState does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[227,26]
package ReplicationProtos does not exist
[ERROR] /testptch/hbase/hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerZKImpl.java:[228,22]
package ReplicationProtos does not exist
[INFO] 32 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
{code}

> [pom cleanup] Move the replication protos into the new hbase-replication module
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-18716
>                 URL: https://issues.apache.org/jira/browse/HBASE-18716
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>
> [~uagashe] has a patch that touches all modules so it is turning up some probs in our
interdependencies. One such is that hbase-replication was getting its generated protobuf files
via transitive include of hbase-protocol-shaded. Better if the protos for replication are
made local to the hbase-replication module since that is our pattern now (colocating protos
w/ their client code inside their hosting module).
> Only issue is that hbase-protocol-shaded content is generated and then relocated which
is a lot of 'pom'-ery to copy/paste. See if can share pom-ery via the parent pom.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message