hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18699) Copy LoadIncrementalHFiles to another package and mark the old one as deprecated
Date Thu, 31 Aug 2017 18:42:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149417#comment-16149417
] 

Appy commented on HBASE-18699:
------------------------------

Two copies of exact same code for full major version ..sigh!
Can we do the following?  Will it be equivalent? Will also allow getting rid of two copies
of TestLoadIncrementalHFilesSplitRecovery.java.
{noformat}
@Deprecated
@InterfaceAudience.Public
public class LoadIncrementalHFiles extends org.apache.hadoop.hbase.tool.LoadIncrementalHFiles
{
  public LoadIncrementalHFiles(Configuration conf) {
    super(conf);
  }
}
{noformat}
We can keep the old run() function and mark it @deprecated if we go this way.
----
redundant import in HadoopSecurityEnabledUserProviderForTesting.
-----


> Copy LoadIncrementalHFiles to another package and mark the old one as deprecated
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-18699
>                 URL: https://issues.apache.org/jira/browse/HBASE-18699
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 3.0.0, 2.0.0-alpha-3
>
>         Attachments: HBASE-18699.patch
>
>
> LoadIncrementalHFiles does not depend on map reduce.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message