hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
Date Sat, 26 Aug 2017 07:23:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142661#comment-16142661
] 

ramkrishna.s.vasudevan commented on HBASE-18692:
------------------------------------------------

I have not checked the code - if the return value is unused then we can revert it. Thanks.

> [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
> -------------------------------------------------------------------------
>
>                 Key: HBASE-18692
>                 URL: https://issues.apache.org/jira/browse/HBASE-18692
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>             Fix For: 2.0.0-alpha-3
>
>
> [~ram_krish] You need this change? BBUtils was public back in 1.0 and
> ByteBufferUtils.copyFromBufferToBuffer
> returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) changed
it to return an int. You think we need this? I can try undoing it. Thanks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message