hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18691) [compat 1-2] HCD remove and removeConfiguration change return type
Date Sun, 27 Aug 2017 09:06:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143046#comment-16143046
] 

Anoop Sam John commented on HBASE-18691:
----------------------------------------

+1

> [compat 1-2] HCD remove and removeConfiguration change return type
> ------------------------------------------------------------------
>
>                 Key: HBASE-18691
>                 URL: https://issues.apache.org/jira/browse/HBASE-18691
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18691.v0.patch
>
>
> Change made in HBASE-18008. Asking [~chia7712] if ok to undo.
> Here is complaint from JACC:
> {code}
> hbase-client-1.2.6.jar, HColumnDescriptor.class
> package org.apache.hadoop.hbase
> [−] HColumnDescriptor.remove ( byte[ ] key )  :  void  1  
> org/apache/hadoop/hbase/HColumnDescriptor.remove:([B)V
> Change	Effect
> 1	Return value type has been changed from void to HColumnDescriptor.	This method has
been removed because the return type is part of the method signature.
> [−] HColumnDescriptor.removeConfiguration ( String key )  :  void  1  
> org/apache/hadoop/hbase/HColumnDescriptor.removeConfiguration:(Ljava/lang/String;)V
> Change	Effect
> 1	Return value type has been changed from void to HColumnDescriptor.	This method has
been removed because the return type is part of the method signature.
> {code}
> Binary breaking but not src breaking. See https://stackoverflow.com/questions/3589946/retrofitting-void-methods-to-return-its-argument-to-facilitate-fluency-breaking
for good discussion. Probably not a prob. but just in case and if not really needed, will
purge.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message