hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
Date Wed, 23 Aug 2017 14:28:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138420#comment-16138420
] 

Mike Drob commented on HBASE-18665:
-----------------------------------

Good find, [~psomogyi]! Do you know what is the impact here?

Performance? Correctness?

> ReversedScannerCallable invokes getRegionLocations incorrectly
> --------------------------------------------------------------
>
>                 Key: HBASE-18665
>                 URL: https://issues.apache.org/jira/browse/HBASE-18665
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>            Reporter: Peter Somogyi
>            Assignee: Peter Somogyi
>
> The behavior of ReversedScannerCallable#prepare [1] and ScannerCallable#prepare [2] methods
differ how they call RpcRetryingCallerWithReadReplicas.getRegionLocations method.
> The reversed scanner uses the 'reload' parameter directly as the first argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload,
id, getConnection(), getTableName(), getRow()) - however, the forward scanner passes '!reload'.
The getRegionLocations first parameter is 'useCache', the way we use it in ScannerCallable
is the correct one.
> The same call can be found in ReversedScannerCallable#locateRegionsInRange [3] also without
negating its value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message