hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
Date Mon, 21 Aug 2017 06:20:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134755#comment-16134755
] 

Appy commented on HBASE-18640:
------------------------------

i have strong gut feeling of having two module: hbase-mapreduce-util (independent of hbase-server)
and hbase-mapreduce, but the our current state of things don't make it easy. So the reasons:
For:
- we have 60 or so classes which don't need hbase-server. Having them separate from the 20
which need hbase-server, feels great right?
Against:
- tests for many of these 60 classes use HBTU, which means their test will have to remain
in either hbase-server (yuk!) or the other module (yuk again!). But these are tests and internal
stuff only, so maybe we okay with this situation
- need tying the two modules together for yetus precommits

However, i still feel that two modules will definitely be a better organization for long term.
And we can move the tests back to right module once testing util is split apart.

> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
>                 Key: HBASE-18640
>                 URL: https://issues.apache.org/jira/browse/HBASE-18640
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-18640.master.001.patch, HBASE-18640.master.002.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively coupled with
visibility labels/wal/filesystem/hfile. These can not be migrated to new module until corresponding
subcomponents are untangled out of hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to hbase-mapreduce
module. Given these dependency constraints, one way would be having a separate module for
tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests 
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in hbase-mapreduce-tests module
if something changed in just hbase-mapreduce. However, yetus' limitation shouldn't warrant
against the idea.
> So i'd say that we should go that way, unless there are better suggestions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message