hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
Date Mon, 28 Aug 2017 23:59:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144564#comment-16144564
] 

Sean Busbey commented on HBASE-18577:
-------------------------------------

{quote}
Why the sadness?
bq. <!-- parent pom defines these for children.    -->
The parent pom can't do it for this sub pom?

Maybe take a look in modules. I think the additions to root pom have mentions in modules.
Could change these to make use of your new addtion?

Looks great.
{quote}

the sadness is because our root pom defines those dependencies for all child poms, regardless
of if we need them. the maven best practice would be to use a {{dependencyManagement}} entry
to do any project-wide configuration or version setting and then only list the dependencies
in modules that need them specifically. It's a refactoring that probably will have a long
tail of side effects, so I don't want to tackle it yet.

> shaded client includes several non-relocated third party dependencies
> ---------------------------------------------------------------------
>
>                 Key: HBASE-18577
>                 URL: https://issues.apache.org/jira/browse/HBASE-18577
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>             Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13
>
>         Attachments: HBASE-18577.6.patch, HBASE-18577-branch-1.v6.patch, HBASE-18577.WIP.0.patch,
HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch,
HBASE-18577.WIP.4.patch, HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch
>
>
> we have some unexpected unrelocated third party dependencies in our shaded artifacts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message