hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiang Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-18573) Update Delete and Append to use Mutation#getCellList(family)
Date Fri, 11 Aug 2017 15:21:00 GMT

     [ https://issues.apache.org/jira/browse/HBASE-18573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Xiang Li updated HBASE-18573:
-----------------------------
    Description: 
In addxxx() of Put and Increment, Mutation#getCellList(family) is called to get cell list
from familyMap. But in the other 2 sub-class of Mutation : Delete and Append, the logic like
Mutation#getCellList(family) is used, like
{code}
    List<Cell> list = familyMap.get(family);
    if(list == null) {
      list = new ArrayList<>(1);
    }
{code}
in
{code}
public Delete addColumn(byte [] family, byte [] qualifier, long timestamp) {
{code}
of Delete

We could make them to call Mutation#getCellList(family) to get better encapsulation

  was:In addxxx() of Put and Increment, Mutation#getCellList(family) is called to get cell
list from familyMap. But in the other 2 sub-class of Mutation : Delete and Append, the logic
like Mutation#getCellList(family) is used. We could make them to call Mutation#getCellList(family)
to get better encapsulation


> Update Delete and Append to use Mutation#getCellList(family)
> ------------------------------------------------------------
>
>                 Key: HBASE-18573
>                 URL: https://issues.apache.org/jira/browse/HBASE-18573
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Xiang Li
>            Assignee: Xiang Li
>            Priority: Minor
>
> In addxxx() of Put and Increment, Mutation#getCellList(family) is called to get cell
list from familyMap. But in the other 2 sub-class of Mutation : Delete and Append, the logic
like Mutation#getCellList(family) is used, like
> {code}
>     List<Cell> list = familyMap.get(family);
>     if(list == null) {
>       list = new ArrayList<>(1);
>     }
> {code}
> in
> {code}
> public Delete addColumn(byte [] family, byte [] qualifier, long timestamp) {
> {code}
> of Delete
> We could make them to call Mutation#getCellList(family) to get better encapsulation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message