hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18554) Append#add doesn't check the row of passed cell
Date Sun, 13 Aug 2017 18:02:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124998#comment-16124998
] 

Anoop Sam John commented on HBASE-18554:
----------------------------------------

So for backward compatibility, we dont throw checked Exception now.  Ideally when we deprecate
some thing in a version, there should be alternate way in that version itself. Then only we
can make sure users use the new way and we can remove in next version.  Now when we add the
checked Exception in 3.0, there also it will be a src compatibility break. (Though it will
be binary compat)
Am not sure what we do here is correct 

> Append#add doesn't check the row of passed cell
> -----------------------------------------------
>
>                 Key: HBASE-18554
>                 URL: https://issues.apache.org/jira/browse/HBASE-18554
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Reid Chan
>              Labels: beginner
>         Attachments: HBASE-18554.master.001.patch, HBASE-18554.master.002.patch
>
>
> {code}
>   @SuppressWarnings("unchecked")
>   public Append add(final Cell cell) {
>     // Presume it is KeyValue for now.
>     byte [] family = CellUtil.cloneFamily(cell);
>     List<Cell> list = this.familyMap.get(family);
>     if (list == null) {
>       list  = new ArrayList<>(1);
>     }
>     // find where the new entry should be placed in the List
>     list.add(cell);
>     this.familyMap.put(family, list);
>     return this;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message