hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-18546) Always overwrite the TS for Append/Increment unless no existing cells are found
Date Wed, 16 Aug 2017 01:00:08 GMT

     [ https://issues.apache.org/jira/browse/HBASE-18546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chia-Ping Tsai updated HBASE-18546:
-----------------------------------
    Attachment: HBASE-18546.v2.patch

> Always overwrite the TS for Append/Increment unless no existing cells are found
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-18546
>                 URL: https://issues.apache.org/jira/browse/HBASE-18546
>             Project: HBase
>          Issue Type: New Feature
>          Components: API, Client
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>              Labels: incompatibleChange
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18546.v0.patch, HBASE-18546.v1.patch, HBASE-18546.v2.patch
>
>
> We don't pass the custom timestamp for Increment, and the increment's timestamp always
be rewrite. Hence, user can't increment a cell with custom timestamp.
> {code:title=ProtobufUtil.java}
>       if (values != null && values.size() > 0) {
>         for (Cell cell: values) {
>           valueBuilder.clear();
>           valueBuilder.setQualifier(UnsafeByteOperations.unsafeWrap(
>               cell.getQualifierArray(), cell.getQualifierOffset(), cell.getQualifierLength()));
>           valueBuilder.setValue(UnsafeByteOperations.unsafeWrap(
>               cell.getValueArray(), cell.getValueOffset(), cell.getValueLength()));
>           if (cell.getTagsLength() > 0) {
>             valueBuilder.setTags(UnsafeByteOperations.unsafeWrap(cell.getTagsArray(),
>                 cell.getTagsOffset(), cell.getTagsLength()));
>           }
>           columnBuilder.addQualifierValue(valueBuilder.build());
>         }
>       }
> {code}
> In contrast to Increment, user can append the cell with custom timestamp. It would be
better that make their behavior consistent. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message