hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18528) DON'T allow user to modify the passed table/column descriptor
Date Mon, 14 Aug 2017 12:17:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125595#comment-16125595
] 

Hudson commented on HBASE-18528:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-2.0 #327 (See [https://builds.apache.org/job/HBase-2.0/327/])
HBASE-18528 DON'T allow user to modify the passed table/column (chia7712: rev fffe4e278d3ec2ccad1b6f16f7e24c5f6b519a0f)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableHTableDescriptor.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ImmutableHColumnDescriptor.java


> DON'T allow user to modify the passed table/column descriptor
> -------------------------------------------------------------
>
>                 Key: HBASE-18528
>                 URL: https://issues.apache.org/jira/browse/HBASE-18528
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, master
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18528.v0.patch, HBASE-18528.v1.patch, HBASE-18528.v2.patch
>
>
> We are replacing the HTableDescriptor by TableDescriptor from code base. The TableDescriptor
is designed to be a read-only object so user can't modifiy it through MasterObserver. HBASE-18502
change many methods of MasterObserver to use TableDescriptor but some deprecated methods still
accept the HTableDescriptor. User may be confused by why some methods can't modify the table
descriptor.
> In short, Should we allow user to modify the passed table descriptor?
> # if yes, we should introduce a mechanism that user can return a modified table descripror
> # if no, we should pass ImmutableHTableDescriptor to user. Or we just remove all methods
accepting the HTableDescriptor
> Ditto for HColumnDescriptor.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message