hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18519) Substitute IndividualBytesFieldCell for CellUtil.createCell
Date Fri, 25 Aug 2017 18:59:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142034#comment-16142034
] 

Chia-Ping Tsai commented on HBASE-18519:
----------------------------------------

bq. This issue has the totally wrong name. 
Sorry, I forgot to update the title..:P 

bq. when we have different Cell implementations – i.e. Cells that are other than KVs –
how would I swap the factory? 
We can add a static method which accepts configuration to pick different builder impl. 

bq. Factory could have a default implementation?
I will move default impl in factory to another class

bq. What we thinking for ByteBufferCell type. Its internal I suppose. Don't have to worry
about it for a while?
I don't find use case that we set all cell's fields one by one for building a ByteBufferCell,
so i leave a TODO in ExtendedCellBuilder.


> Substitute IndividualBytesFieldCell for CellUtil.createCell
> -----------------------------------------------------------
>
>                 Key: HBASE-18519
>                 URL: https://issues.apache.org/jira/browse/HBASE-18519
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18519.v0.patch, HBASE-18519.v1.patch, HBASE-18519.v2.patch
>
>
> The IndividualBytesFieldCell, which is introduced by HBASE-14882, carries the input arguments
without copying.  We can substitute IndividualBytesFieldCell for CellUtil.createCell.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message