hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chia-Ping Tsai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18515) Introduce Delete.add as a replacement for Delete#addDeleteMarker
Date Sat, 05 Aug 2017 16:20:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115440#comment-16115440
] 

Chia-Ping Tsai commented on HBASE-18515:
----------------------------------------

LGTM. 
Do you mind replacing the addDeleteMarker() by add() from the code base?

>  Introduce Delete.add as a replacement for Delete#addDeleteMarker
> -----------------------------------------------------------------
>
>                 Key: HBASE-18515
>                 URL: https://issues.apache.org/jira/browse/HBASE-18515
>             Project: HBase
>          Issue Type: Task
>          Components: Client
>            Reporter: Chia-Ping Tsai
>            Assignee: Xie YiFan
>              Labels: beginner
>             Fix For: 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18515.master.v0.patch, HBASE-18515.master.v1.patch, HBASE-18515.master.v2.patch,
HBASE-18515.master.v3.patch
>
>
> {quote}
>   public Delete addDeleteMarker(Cell kv) throws IOException {
>     // TODO: Deprecate and rename 'add' so it matches how we add KVs to Puts.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message