hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18509) [HLC] Finishing cleanups
Date Wed, 16 Aug 2017 02:52:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128229#comment-16128229
] 

Hudson commented on HBASE-18509:
--------------------------------

FAILURE: Integrated in Jenkins build HBASE-14070.HLC #221 (See [https://builds.apache.org/job/HBASE-14070.HLC/221/])
HBASE-18509 Cleanup Clock interface. (appy: rev 82a9cec595d165a715a0406e5b280bec8fcf0e88)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/SystemMonotonicClock.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/HybridLogicalClock.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestClockWithCluster.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionSplitPolicy.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TimestampType.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/SystemClock.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCopyTable.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/Clock.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/SettableTimestamp.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestCellACLWithMultipleVersions.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactingMemStore.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ClockType.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestTimestampType.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestWALReplay.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
* (add) hbase-common/src/main/java/org/apache/hadoop/hbase/ClockException.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestIncrementTimeRange.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableDescriptorBuilder.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWALLockup.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestClock.java


> [HLC] Finishing cleanups
> ------------------------
>
>                 Key: HBASE-18509
>                 URL: https://issues.apache.org/jira/browse/HBASE-18509
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Appy
>            Assignee: Amit Patel
>         Attachments: HBASE-18509.HBASE-14070.HLC.001.patch
>
>
> Track all types of cleanups here:
> - (done in 001.patch) --Rename classes to more consistent naming: SystemClock, SystemMonotonicClock,
HybridLogicalClock--
> - (done in 001.patch) --Move implementations out from Clock interface. It's a simple
interface of 6 fns but very overloaded right now with everything put inside it.--
> - Move to separate module/package/both
> - Maybe encapsulate all clocks in RS/Master into a new class. Then RSServices can just
have getClocks() function.
> {noformat}
> class Clocks {
>   // all 3 types of clocks.
>   // Fns:
>   - update(ClockType, timestamp)
>   - updateAll(List\<NodeTime>)
>   - int64 now(ClockType)
>   - List\<NodeTime> nowAll()
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message