hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18431) Mitigate compatibility concerns between branch-1.3 and branch-1.4
Date Tue, 01 Aug 2017 00:53:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108225#comment-16108225
] 

Hadoop QA commented on HBASE-18431:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 38s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color}
| {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 24s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 40s{color}
| {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 50s{color} |
{color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 21s{color}
| {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 47s{color}
| {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 23s{color} |
{color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 43s{color} |
{color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 19s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 54s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 52s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  0m 52s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 52s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 35s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  0m 31s{color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red}
The patch has 55 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>.
Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  0m 46s{color} | {color:red}
The patch causes 16 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  1m 30s{color} | {color:red}
The patch causes 16 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 13s{color} | {color:red}
The patch causes 16 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  2m 57s{color} | {color:red}
The patch causes 16 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  3m 41s{color} | {color:red}
The patch causes 16 errors with Hadoop v2.5.2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}  0m 57s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 10s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 41s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 18s{color} | {color:green}
hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 36s{color} | {color:green}
hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 22s{color} | {color:green}
hbase-rsgroup in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 22s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 73m 49s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:757bf37 |
| JIRA Issue | HBASE-18431 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12879742/HBASE-18431-branch-2-WIP.patch
|
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  cc  hbaseprotoc  |
| uname | Linux 7b92af8ef5e4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-2 / 7bdabed |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC3 |
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/7858/artifact/patchprocess/whitespace-eol.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/7858/testReport/ |
| modules | C: hbase-protocol hbase-client hbase-rsgroup U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/7858/console |
| Powered by | Apache Yetus 0.4.0   http://yetus.apache.org |


This message was automatically generated.



> Mitigate compatibility concerns between branch-1.3 and branch-1.4
> -----------------------------------------------------------------
>
>                 Key: HBASE-18431
>                 URL: https://issues.apache.org/jira/browse/HBASE-18431
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Blocker
>             Fix For: 1.4.0, 1.5.0
>
>         Attachments: HBASE-18431-branch-1.4.patch, HBASE-18431-branch-1.patch, HBASE-18431-branch-2-WIP.patch
>
>
> There are compatibility concerns with branch-1.4. 
> {noformat}
> Library Name	HBase
> Version #1	1.3.1
> Version #2	1.4.0-SNAPSHOT
> Subject	Binary Compatibility
> Compatibility - 89.9%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> 	High - 23
> 	Medium - 9
> 	Low - 21
> {noformat}
> {noformat}
> Library Name	HBase
> Version #1	1.3.1
> Version #2	1.4.0-SNAPSHOT
> Subject	Source Compatibility
> Compatibility- 86.5%
> Added Methods - 305
> Removed Methods - 105
> Problems with Data Types
> 	High - 88
> 	Medium - 0
> 	Low - 0
> Other Changes in Data Types	 - 25
> {noformat}
> This report includes HBASE-15816 which hasn't been committed yet. Otherwise it's current.
> I'm not generally concerned with added methods. 
> The following methods have been added to Public/Evolving interface Table. Pointing them
out in case it merits review.
> \\
> * Abstract method Table.getReadRpcTimeout ( ) has been added to this interface.	No effect.
> * Abstract method Table.getWriteRpcTimeout ( ) has been added to this interface.	No effect.
> * Abstract method Table.setReadRpcTimeout ( int ) has been added to this interface.	No
effect.
> * Abstract method Table.setWriteRpcTimeout ( int ) has been added to this interface.
> The Public/Evolving interface Admin has some signature changes equating to removed methods.
I don't think this is allowed in a minor release.
> \\
> * Abstract method Admin.isSnapshotFinished ( HBaseProtos.SnapshotDescription ) has been
removed from Admin.
> *  Abstract method Admin.snapshot ( String, TableName, HBaseProtos.SnapshotDescription.Type
) has been removed from Admin.
> * Abstract method Admin.snapshot ( HBaseProtos.SnapshotDescription ) has been removed
from Admin.
> *  Abstract method Admin.takeSnapshotAsync ( HBaseProtos.SnapshotDescription ) has been
removed from Admin.
> The LimitedPrivate(CONFIG) interface AsyncRpcClient has been removed. This change is
debatable but I think we can allow it.
> \\
> * AsyncRpcClient has been removed
> The Public/Evolving class FastLongHistogram has been removed. I don't believe this change
is allowed in a minor release.
> \\
> * FastLongHistogram has been removed
> Method signatures in LimitedPrivate(COPROC) interfaces MasterObserver and RegionObserver
have changed, equating to removed methods. The first set of changes is due to move of SnapshotDescription
from HBaseProtos to SnapshotProtos:
> \\
> * Abstract method MasterObserver.postCloneSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postDeleteSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postListSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postRestoreSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> * Abstract method MasterObserver.postSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preCloneSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preDeleteSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preListSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preRestoreSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> * Abstract method MasterObserver.preSnapshot ( ObserverContext<MasterCoprocessorEnvironment>,
HBaseProtos.SnapshotDescription, HTableDescriptor ) has been removed from MasterObserver.
> Here, maybe DeleteTracker moved packages?
> \\
> * Abstract method RegionObserver.postInstantiateDeleteTracker ( ObserverContext<RegionCoprocessorEnvironment>,
DeleteTracker ) has been removed from RegionObserver.
> The LimitedPrivate(COPROC) interface Store has method signature changes equating to removed
methods. The changes are debatable. I am thinking we can allow them. Anyone implementing their
own Stores?
> \\
> * Abstract method Store.bulkLoadHFile ( String, long ) has been removed from Store.
> * Abstract method Store.getScanners ( List<StoreFile>, boolean, boolean, boolean,
boolean, ScanQueryMatcher, byte[ ], byte[ ], long, boolean ) has been removed from Store.
> * Abstract method Store.getScanners ( boolean, boolean, boolean, boolean, ScanQueryMatcher,
byte[ ], byte[ ], long ) has been removed from Store.
> * Abstract method Store.upsert ( Iterable<Cell>, long ) has been removed from Store.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message