hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18303) Clean up some parameterized test declarations
Date Thu, 17 Aug 2017 19:28:03 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131143#comment-16131143
] 

Hudson commented on HBASE-18303:
--------------------------------

FAILURE: Integrated in Jenkins build HBASE-14070.HLC #233 (See [https://builds.apache.org/job/HBASE-14070.HLC/233/])
HBASE-18303 Clean up @Parameter boilerplate (mdrob: rev 0b26ccdaa1b8700e7958aeebbaf9cad81e737dd0)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV3.java
* (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestMultiRowResource.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestKeyOnlyFilter.java
* (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/keyvalue/TestKeyValueTool.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java
* (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestRowEncoder.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/types/TestStruct.java
* (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestByteBufferUtils.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java


> Clean up some parameterized test declarations
> ---------------------------------------------
>
>                 Key: HBASE-18303
>                 URL: https://issues.apache.org/jira/browse/HBASE-18303
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18303.patch, HBASE-18303.patch
>
>
> While debugging something unrelated, I noticed that we use the constructor form of junit
parameterized tests, instead of the annotated members form.
> I personally find using the @Parameter annotation more clear.
> Also, we can move the parameter generator to hbase-common so that it is accessible in
more modules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message