hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18271) Shade netty
Date Fri, 11 Aug 2017 18:38:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123820#comment-16123820
] 

Mike Drob commented on HBASE-18271:
-----------------------------------

{quote}
In essence we need the below define whenever we run: 

-Dorg.apache.hadoop.hbase.shaded.io.netty.packagePrefix=org.apache.hadoop.hbase.shaded.
{quote}

When we run what? Compile? Tests? Deploy?
I see that we set the value in the pom.xml now. Is that sufficient for all cases?

Should we attempt to set the system property in Master/RegionServer startup before the netty
classes are loaded or something like that?

> Shade netty
> -----------
>
>                 Key: HBASE-18271
>                 URL: https://issues.apache.org/jira/browse/HBASE-18271
>             Project: HBase
>          Issue Type: Sub-task
>          Components: rpc
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18271.master.001.patch, HBASE-18271.master.002.patch, HBASE-18271-Shade-netty-Purge-mention-of-netty-all.003.patch
>
>
> Our new prefatory project, hbase-thirdparty, includes a relocated netty 4.1.12. This
issue is about changing references in hbase to make use of this shaded netty. This way we
will take ourselves out of the clashing library saga and change netty as we see fit.
> One kink is the inclusion inside the netty-all jar of an .so. We need to make sure it
gets loaded and that on linux we are doing native epoll; all should be in place to do this
but need to add a system property to bin/hbase for netty to pick up. TODO as part of this
issue. See tail of upgrade guava sibling issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message