hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18251) Remove unnecessary traversing to the first and last keys in the CellSet
Date Wed, 16 Aug 2017 12:53:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128747#comment-16128747
] 

Hudson commented on HBASE-18251:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3542 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3542/])
HBASE-18251 Remove unnecessary traversing to the first and last keys in (ramkrishna: rev 9da4e6906e9d7f62b8a8fe5dc996b066dac4066e)
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CellSet.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CellFlatMap.java


> Remove unnecessary traversing to the first and last keys in the CellSet
> -----------------------------------------------------------------------
>
>                 Key: HBASE-18251
>                 URL: https://issues.apache.org/jira/browse/HBASE-18251
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha-1
>            Reporter: Anastasia Braginsky
>            Assignee: Toshihiro Suzuki
>             Fix For: 3.0.0, 1.4.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18251.patch, HBASE-18251-v2.patch, HBASE-18251-v2.patch
>
>
> The implementation of finding the first and last keys in the CellSet is as following:
> {code}
>  public Cell first() {
>     return this.delegatee.get(this.delegatee.firstKey());
>   }
>   public Cell last() {
>     return this.delegatee.get(this.delegatee.lastKey());
>   }
> {code}
> Recall we have Cell to Cell mapping, therefore the methods bringing the first/last key,
which allready return Cell. Thus no need to waist time on the get() method for the same Cell.
> Fix: return just the first/lastKey(), should be at least twice more effective.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message