hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18127) Enable state to be passed between the region observer coprocessor hook calls
Date Wed, 02 Aug 2017 06:17:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110381#comment-16110381
] 

Lars Hofhansl commented on HBASE-18127:
---------------------------------------

+1 on using interfaces.

Quick questions:
# what about the single hooks? In that case opContext might be null? (Just talked with [~abhishek.chouhan],
it seems the single hooks are only called from Region.batchMutate, so we should be good).
# Should we only create the HashMap upon first use? 99.999% of the calls will not use this.
# Lastly, [~jamestaylor], the motivation came because Phoenix does work in the batch hooks
_and_ the single hooks. Since the single hooks are _only_ called from the batchMutate, we
should be able to not do any work in the single hooks and not have this problem in the first
place.



> Enable state to be passed between the region observer coprocessor hook calls
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-18127
>                 URL: https://issues.apache.org/jira/browse/HBASE-18127
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Abhishek Singh Chouhan
>         Attachments: HBASE-18127.master.001.patch, HBASE-18127.master.002.patch, HBASE-18127.master.002.patch
>
>
> Allow regionobserver to optionally skip postPut/postDelete when postBatchMutate was called.
> Right now a RegionObserver can only statically implement one or the other. In scenarios
where we need to work sometimes on the single postPut and postDelete hooks and sometimes on
the batchMutate hooks, there is currently no place to convey this information to the single
hooks. I.e. the work has been done in the batch, skip the single hooks.
> There are various solutions:
> 1. Allow some state to be passed _per operation_.
> 2. Remove the single hooks and always only call batch hooks (with a default wrapper for
the single hooks).
> 3. more?
> [~apurtell], what we had discussed a few days back.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message