hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-18125) HBase shell disregards spaces at the end of a split key in a split file
Date Thu, 17 Aug 2017 04:18:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-18125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129878#comment-16129878
] 

Hudson commented on HBASE-18125:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-2.0 #343 (See [https://builds.apache.org/job/HBase-2.0/343/])
HBASE-18125 shell disregards spaces at the end of a split key in a split (stack: rev 242ccd5881c23ae55f95e1db54dbcf1b0934f521)
* (edit) hbase-shell/src/main/ruby/hbase/admin.rb


> HBase shell disregards spaces at the end of a split key in a split file
> -----------------------------------------------------------------------
>
>                 Key: HBASE-18125
>                 URL: https://issues.apache.org/jira/browse/HBASE-18125
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 2.0.0, 1.3.1
>            Reporter: Ashu Pachauri
>            Assignee: Chenxi Tong
>              Labels: beginner
>             Fix For: 2.0.0, 1.4.0, 1.3.2, 1.2.7, 1.1.13
>
>         Attachments: HBASE-18125.patch
>
>
> When converting row keys to a printable string representation, Bytes class considers
SPACE as a printable character, so it prints it out as it is. So, it's quite possible that
a row key has a space at the end.
> When specifying split points in a file, the row keys are not quoted and the shell wrapper
"admin.rb" strips any whitespace off the row keys:
> {code}
>  File.foreach(splits_file) do |line|
>             arg[SPLITS].push(line.strip())
>           end
> {code}
> The correct approach is to use "chomp()" instead of "strip()" to just strip off carriage
returns and newlines. We should assume that the hbase user is either using split points printed
out by hbase itself (which will not have tabs) or is diligent enough to not use tabs at the
end of a split point.
> What's worse is that it goes undetected and will result in undesirable split points.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message