hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17614) Move Backup/Restore into separate module
Date Wed, 16 Aug 2017 02:51:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128227#comment-16128227

Josh Elser commented on HBASE-17614:

Thanks for the quick turnaround, Vlad! Looks pretty good overall.

Looks like you have some unnecessary dependencies in hbase-backup. I believe all of the following
can be dropped (a trivial build passed locally):

* org.apache.hbase:hbase-protocol
* org.apache.htrace:htrace-core
* org.codehaus.jackson:jackson-mapper-asl
* org.jruby.jcodings:jcodings
* org.jruby.joni:joni
* io.dropwizard.metrics:metrics-core

You can drop {{protobuf-maven-plugin}} from hbase-backup/pom.xml completely. I don't think
this is actually doing anything (but could be mistaken).

Please make the module name in the hbase-backup/pom.xml {{Apache HBase - Backup}} for consistency
with the other modules.

Note to self: Make sure to get the right parent-pom version in hbase-backup/pom.xml for master
and branch-2 (they differ).

> Move Backup/Restore into separate module 
> -----------------------------------------
>                 Key: HBASE-17614
>                 URL: https://issues.apache.org/jira/browse/HBASE-17614
>             Project: HBase
>          Issue Type: Task
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>            Priority: Blocker
>              Labels: backup
>             Fix For: 2.0.0
>         Attachments: HBASE-17614-v1.patch
> Move all the backup code into separate hbase-backup module.

This message was sent by Atlassian JIRA

View raw message